Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: organize build flags #1371

Merged
merged 4 commits into from
Dec 31, 2023
Merged

chore: organize build flags #1371

merged 4 commits into from
Dec 31, 2023

Conversation

EmosewaMC
Copy link
Collaborator

closes #1369

Heavily optimize the build pipeline to reduce extra work done by compiler.

  • Remove all global pre-processor defines
  • Only define variables at the appropriate level (CDCLIENT_CACHE_ALL for dDatabase only instead of globally)
  • Remove redundant work
  • Always copy sql files on cmake to ensure they are the same as main
  • consolidate compiler flag setting
  • remove redundant includes paths

Now to build this on 4 different platforms. Yay.

Don't be default incluyde bcrypt so you need to specify the folder.  Allows pre-processor to find the correct file.
dCommon/Game.h Outdated Show resolved Hide resolved
@EmosewaMC EmosewaMC marked this pull request as draft December 30, 2023 11:05
@EmosewaMC EmosewaMC marked this pull request as ready for review December 31, 2023 06:10
@EmosewaMC
Copy link
Collaborator Author

I have made sure this builds on windows and linux and mac.

@aronwk-aaron aronwk-aaron merged commit e54faa3 into main Dec 31, 2023
3 checks passed
@aronwk-aaron aronwk-aaron deleted the 1369 branch December 31, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: clean up build pipeline further
4 participants